-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance Container for asynchronous tasks #1
base: main
Are you sure you want to change the base?
Conversation
_sources/canasta/CanastaUtils.php
Outdated
/** | ||
* Not exactly a utility function, but - show a warning to users if $wgSMTP is not set. | ||
*/ | ||
$wgHooks['SiteNoticeAfter'][] = function ( &$siteNotice, Skin $skin ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed in maintenance container
_sources/configs/.htaccess
Outdated
@@ -0,0 +1,45 @@ | |||
RewriteEngine On |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire file is not necessary in this container and should be removed
_sources/configs/default.vcl
Outdated
@@ -0,0 +1,149 @@ | |||
vcl 4.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire file is unnecessary in this container
_sources/configs/robots.txt
Outdated
@@ -0,0 +1,10 @@ | |||
User-agent: * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary file
I have deleted the files as per the request. |
Hi @jeffw16, I was wondering if you had a chance to review my edits, and if there's anything I can do to help move the task forward. Please let me know if any further changes are required. Thanks |
No, I have not had a chance to review your edits again. Sorry for taking so long; your patience is appreciated. In case you are wondering if it looks bad to have a PR not merged in for being selected as a GSoC contributor: no, it's not. We're not counting it against any candidate who has a reasonable first draft of their code submitted in a PR. :) |
Related issue Canasta#33
Related PRs Canasta#266, Canasta-DockerCompose#42
This PR adds a separate container to run maintenance script for MediaWiki installation
changes
The changes have been made using the base code from canasta and include the following modifications:
Dockerfile
andrun-apache.sh
along with related configuration filestesting
maintainance
containerThe sitemap script is disabled by default; It was enabled for testing purposes.
docker-image.yml
from the Canasta repository to make it work for this repositoryconcurrency
on.push.branches
env.IMAGE_NAME
Image_ID
I'm unfamiliar with GitHub workflow, so I cannot be sure if I have covered everything. Please let me know if I have missed something
I have tested the changes made by importing an existing wiki as well as creating a new one
PS- to locally test please edit the
docker-compose.override.yml
to point to the local images as there is no image in registry for this container