-
-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Model.scoped deprecation #17
Comments
As far as I see this even causes an exception in rails 4.1.0.rc1 ( |
From what I understand, to support the functionality provided by I'll see about fixing this, I'm trying to get the testing framework for Cancancan turned around, since it was originally built with Supermodel and WithModel... both of which don't work with rails > 3.0 So I don't actually even have tests for rails 3.1, 3.2 or 4 yet. |
Looks good, for me https://github.com/lacco/cancancan/commit/a98612ec98f800c464110355386337b29d9c725f works. So using |
Closing this as fixed in #21 |
https://github.com/CanCanCommunity/cancancan/blob/master/lib/cancan/model_adapters/active_record_adapter.rb#L100 is still using #scoped. This causes a deprecation warning in Rails 4. Use #all instead if the Rails version is 4 or greater.
The text was updated successfully, but these errors were encountered: