Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons: Revert package json change #406

Merged
merged 1 commit into from
May 9, 2024
Merged

Conversation

somethiiing
Copy link
Contributor

removing the exports field in the packagejson

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2024 5:38pm

Copy link

changeset-bot bot commented May 9, 2024

⚠️ No Changeset found

Latest commit: 20fe841

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zprong
Copy link
Contributor

zprong commented May 9, 2024

heads up: I don't actually know what having the exports field in package.json did

@somethiiing
Copy link
Contributor Author

heads up: I don't actually know what having the exports field in package.json did

so our current import we'd need to do import Accent from "@cambly/syntax-icons/dist/Icons the exports is supposed to make it so we skip the dist file. BUT, because of: microsoft/TypeScript#51862 (comment), it doesnt actually work entirely.

according to christian, we'd have to fix this in Cambly-Frontend We need to update our moduleResolution to nodenext to resolve this issue. but that will be a future fix

@somethiiing somethiiing merged commit 9623cb9 into main May 9, 2024
10 checks passed
@somethiiing somethiiing deleted the Icons/update-packagejson-fix branch May 9, 2024 19:25
@zprong
Copy link
Contributor

zprong commented May 9, 2024

thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants