-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V4.0 Documentation #709
Comments
See also #634 |
Thanks for stepping up here. |
I don't use Caliburn.Micro across a wide enough set of scenarios (and so far only on 3.2) to take a huge amount on but I'd like to see it continue. Hopefully there will be enough people in the community to work together to take it forward and I'm happy to help out where I can. I've started trying to piece together a list of the key changes from 3.2 to 4.0 so that I can assess gaps in the documentation but if you had a few minutes to simply dump a list in this thread that would be great. I guess the big thing is async support? |
@KasperSK referencing #708 (comment) I've created this issue to gather together thoughts and specific changes we might want to do to the documentation for V4.0. Please feel free to contribute (see my comment above - this is going to need to be a group effort). |
I really like this project and I use it in every WPF+MVVM project of mine. |
Looking at the issues in https://github.com/Caliburn-Micro/Caliburn.Micro/milestones could help with finding the key changes. I have been developing WPF applications and now I am developing for Xamarin Forms, so I can probably contribute with some input regarding Xamarin Forms usage. Regarding what changes need to be done I think we should update the getting started portion so that it reflects how to setup a project on each platform. Maybe update the In the 'Soup to Nuts' section over all i think we need to remove references to platform that are no longer supported. I have looked the sections over briefly and added some comments below:
8.1 View / ViewModel Naming Conventions, this section looks good i dont' think conventions has changed. 8.2 Handling Custom Conventions, this section looks good i don't think conventions has changed. 8.3 Using the NameTransformer, this section looks good i don't think conventions has changed.
I think we might also need a section on how the navigation service is used as that is quite useful on mobile platforms. I don't know if i missed anything but I do think the existing documentation is a good starting point for this. I think I will focus on the working with Xamarin Forms section that need to be added for a start. Regarding tracking the work would it be better to do an issue for each section that need a rewrite so the sections can be assigned to avoid dual work? And should we do it in the repo that holds the documentation? |
Regarding the Start package, I had spent a little bit of time in building new templates based off |
I wonder if we risk losing the bigger picture if we move all the documentation discussion to the other repo. What do people think about keeping the discussion here around what to do for a V4.0 doc release and create issues for the specific items in the other repo? I can link the specific items into this issue so we have a record of the discussion in one place. I've not done a lot of open source development on GitHub though so I can imagine that those with experience may know where the pitfalls are. @KasperSK I think a "Migrating to 4.0.0" section seems good - I think I came across one place recently where I was forced to use async where I hadn't previously had to for example. If we are going to create specific issues in the other repo then that seems like a good starting point - the detail discussion could then happen there. I've not had a chance to explore the other proposals more than a quick glance (looks good) but will endeavour to comment in detail soon. Hopefully others will feel able to chip in too. |
@mbreckon I think you are right lets keep the bigger picture in this thread and then make smaller issues for detailed discussion. I have made an issue regarding the migration to 4.0.0 part of the documentation here: Migrating to 4.0.0 issue |
Something to make clear in the UWP platform section - namespace syntax! Issue 710 |
I would love to help with documentation. |
@CoreyVincent I have started to work on the documentation but it is a work in progress, any feedback would be nice. |
@KasperSK great, I'll start taking a look at that and hopefully give some useful feedback. |
@KasperSK @CoreyVincent @mbreckon Thanks for doing this |
@KasperSK I submitted some suggested changes to the Introduction. Not sure if I did it correctly. Also, where can I place images that go with the document? |
Currently documentation images are stored in https://github.com/Caliburn-Micro/caliburn-micro.github.io/tree/master/public/images/documentation |
@CoreyVincent did you fork the documentation repository? |
@KasperSK I forked the one that you forked, so that you could pull it into the stuff you already worked on. Though I could just fork the master. Let me know what would be best. |
@nigel-sampson @vb2ae Should the Documentation be updated at least to say the project is being maintained again? A lot of people are being turned away from the project seeing that on the homepage of the website. |
@CoreyVincent Did you push your changes to github? Edit: Never mind I found your changes. |
@CoreyVincent yes please |
@KasperSK @nigel-sampson Was that the proper way for me to submit changes? What repo should I be pulling from? |
Also, is there any reason why we don't just switch to a wiki on the github page? |
The other repository is a GitHub pages site powering https://caliburnmicro.com/ PR's merged here will update the website in a few minutes. |
Multi language switch in document page is greet. In this way, I can also contribute. |
@a44281071 I like the idea. Which languages would you add? |
@vb2ae Chinese language. |
With reference to this issue #708 it is clear that Nigel is going to be stepping back from maintaining Caliburn Micro. I'm a grateful user of the framework and still use it regularly (doing engineering apps in WPF on desktop systems).
The documentation has however been minimal at best and threatens now to be completely out of date.
Nigel has suggested #708 (comment) he is prepared to merge PR requests for documentation (something I'm prepared to contribute some time to) but there is a risk we end up all working on the same thing.
I've opened this issue as a proposal to have a single issue that tracks thoughts on the current documentation and what needs doing.
Approach
We've decided to use this issue to plan and collate all the top-level work that needs to be done for the V4.0.0 documentation. We will then use individual issues in the website repository to discuss the finer details.
Current planned work
The text was updated successfully, but these errors were encountered: