Using a TabbedPage for you root view will add tabs multiple times

[johot]

Update: Might have found the bug

It seems InitializeComponent(); gets called twice for ViewLocator.LocateForModel because of the following code:

public static void InitializeComponent(object element) {
#if !WinRT && !XFORMS
            var method = element.GetType()
                .GetMethod("InitializeComponent", BindingFlags.Public | BindingFlags.Instance);
#else
            var method = element.GetType().GetTypeInfo()
                .GetDeclaredMethods("InitializeComponent")
                .SingleOrDefault(m => m.GetParameters().Length == 0);
#endif

            if (method == null)
                return;

            method.Invoke(element, null);
        }

Since a default implementation using xaml + code behind has a call to InitializeComponent() in it's constructor I believe maybe we should simply let the code behind file call it?

Original description

I used the default Caliburn.Micro sample with Xamarin.Forms and modified my HomeView.xaml file to use a tabbed page:

<?xml version="1.0" encoding="utf-8" ?>
<TabbedPage xmlns="http://xamarin.com/schemas/2014/forms"
             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
             x:Class="Setup.Forms.Views.HomeView">
    <ContentPage Title="First tab">
        <Label Text="Testing first tab">
            
        </Label></ContentPage>
    <ContentPage Title="Second tab">
        <Label Text="Testing second tab"></Label>
    </ContentPage>
</TabbedPage>

The view will show up but now the tabs have been added multiple times (4 times instead of 2). I've located the error to something happening inside the ViewLocator.LocateForModel(viewModel, null, null); code. If I do a new HomeView() the problem will not appear.

Note:

I've also seen this when using the NavigationService. In this case a toolbar button was added multiple times. I am guessing it also uses ViewLocator.LocateForModel internally? It's like all Xaml gets evaluated twice or something.

Here's a picture of the result:

[nigel-sampson]

Thanks for this, I'll have to look into the generated code by Xamarin.Forms. The other xaml platforms have guards in to detect duplicate initialization, it appears XF doesn't.

This is here to support xaml files without a code behind which admittedly isn't a highly used feature.

[nigel-sampson]

I've pushed a change that doesn't call InitializeComponent on Xamarin.Forms.

[johot]

Hi @nigel-sampson!

Thank you for fixing this so fast!
I hope we can see this in a relase real soon, good work!