Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fluids interact better with blocks with full side faces #2922

Open
muzikbike opened this issue Dec 7, 2024 · 1 comment
Open

Make fluids interact better with blocks with full side faces #2922

muzikbike opened this issue Dec 7, 2024 · 1 comment
Labels
S-needs-triage Status: Needs triage T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link
Contributor

Request Description

Not sure how much we want to deviate from vanilla, but when it comes to rendering against blocks with full sides, many inconsistencies are to be found. Here's some pictures:
2024-12-07_16 23 22
2024-12-07_16 24 55
2024-12-07_16 26 30
2024-12-07_16 47 25
2024-12-07_16 56 39

In some cases, the sides are culled; in others, they're not.

IMO for opaque blocks, the faces should definitely be culled. For visually transparent blocks, the interior faces should use the "plain" texture which is visible from the outside when water is against glass, for example (https://bugs.mojang.com/browse/MC-271735).

Sodium previously did something much more extreme, which was obviously undesirable (#991). The ideal outcome is to find a middle ground which visually makes sense.

@muzikbike muzikbike added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels Dec 7, 2024
@douira
Copy link
Collaborator

douira commented Dec 7, 2024

An inside overlay is shown depending on whether the block is marked as "transparent". This is decided by FluidRenderHandlerRegistry on fabric, and neoforge has a similar mechanism. I don't think we want to change this because this behavior is presumably relied on by mods because they can specifically configure it and I don't think there's a more reasonable classification of blocks to show overlays for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-triage Status: Needs triage T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants