Dark chunks still occur with Phosphor 7.1

[CalXee]

The dark chunk issue can still be reproduced in version 7.1 by entering a nether portal and repeating that for a long time. This is a rare occurrence but one nonetheless.

https://www.youtube.com/watch?v=mGDKO5sPvdQ
profile-results-2021-03-27_14.41.33.txt
debug-report-2021-03-27_14.41.43.zip

Note in the attached video, I was using standalone Phosphor 7.1 with NO OTHER MODS, not even Modmenu or Fabric API.

[mrmangohands]

Thank you for showing this video, I've been going crazy trying to figure out what was constantly causing lighting glitches in my chunks. I'd come back from the Nether and have 4 more straight black chunks... was getting to the point I'd be spending most of my game time trying to fix the lighting issues.
I'm just gonna remove all of this devs mods. They almost never get updated and cause major issues when something does go wrong. It's a same, they really do help performance, but it's too steep a cost, especially with no/very little attention given to these major bugs.

Frankly this is the only known issue of this severity in either Lithium or Phosphor at the moment, and until an hour ago we'd had a single report of it in the two months this release has been out. Generally we get to such issues quite quickly, but PhiPro has not had much time available lately, and the last issue of this variety took several of us many hours to debug, and additionally we can't even be sure whether these are actually phosphor issues or rather vanilla bugs that're usually masked until we've found the root cause.

[PhiProven]

I have fixed one possible cause for this issue in 7b32057.
However, due to the irreproducibility of this bug, I can't tell whether this actually was the cause or not.
So let me know if you still encounter the issue with this build. Please relight the world once when updating (or create a new world) in order to remove all previous glitches.

[coderbot16]

I've been relighting chunks manually thanks to this. I love how you suggest to make a new world, as if all the time spent in the world and things built should just be forgotten because of your glitchy mod.

It's trivial to relight the entirety an existing world through the Optimize World dialog. Creating a new world was simply a suggestion in the case that users were creating temporary test worlds or similar, such as what CalXee was doing.

That's the kind of response right there that makes me happy I'm not running anything JellySquid has had their hands on and never will again. Piss poor, plain and simple.

Tell us, how would you have handled this better?

By the way, I'm very happy to report I've not had a single new lighting issue since removing your mods. It's been wonderful.

Feel free to not use the mods, nobody is forcing you to do so. But I don't see what you intend to accomplish through being a dick on the issue tracker.

[mrmangohands]

@BBloom81 you can relight chunks in your existing world by launching the server with --forceUpgrade --eraseCache. If you're in single player it's edit -> optimize world -> erase cached data.

[CalXee]

I believe it's only ethical and productive to use issue trackers to bring issues to light and get them fixed with the intention of making the mod better; not to insult the mod or it's developers.

[jellysquid3]

@BBloom81 Disrupting our issue tracker to raise your grievances with a project given to you for free, without any strings attached, while our volunteers attempt to resolve the bug at hand, is not a productive use of anyone's time. Your attitude and tone is not welcomed nor helpful, and you have taken to giving the most uncharitable interpretation of our words at every opportunity. I will not be entertaining it any further.

At risk of stating the obvious, we do care about issues, and we know that there are likely a few still lurking -- hence the reason the mods are still in their 0.x (alpha) series. Some issues are inherently more complex to resolve than others, especially ones like this that involve deeply intricate and complex threading code. As a result we have to rely on user reports and confirmation to be absolutely certain a problem is resolved, and in this case, we left the issue open for that very reason.

[PhiProven]

I call this one fixed in 0.7.2.
Please open a new report if some new glitches show up in 0.7.2.