Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TNT machines deadlock the client #36

Closed
robot4jarvis opened this issue Jan 24, 2021 · 14 comments
Closed

TNT machines deadlock the client #36

robot4jarvis opened this issue Jan 24, 2021 · 14 comments
Labels
1.16.x bug Something isn't working critical This issue is of critical importance

Comments

@robot4jarvis
Copy link

Reproduction Step

  1. Start a redstone machine that generates TNT continuously (with one to two TNT at a time it's enough).
  2. Wait for some seconds or minutes.
  3. The game crashes

Crash Report File

No crash report was generated.

Additional Information

It has happened many times.

@Roan-V
Copy link

Roan-V commented Jan 24, 2021

Can you share a crash log?

@2No2Name
Copy link
Member

If there is no crash report, please provide the log file

@robot4jarvis
Copy link
Author

robot4jarvis commented Jan 24, 2021

latest.log
Btw, the name of the world is "Smooth Wall Trenchers" and I was using the latest version of fabric, the fabric API, MaLibLib, Linematica, Sodium, Lithium and Phosphorus.
In this last case, it didn't crash with only two TNT's (even though it happened to me previously) but with around 12 TNT's (something that my computer is completely able to handle).
I reinstalled all the mods this afternoon trying to solve the issue, but it keeps happening.

@Kroppeb
Copy link

Kroppeb commented Jan 24, 2021

Huh, the logs don't seem to indicate a crash happend at all. There are a lot of warnings however, but none seem to cause any real issues.
Does the game completely crash or does it freeze. And if it crashes, could you provide a screenshot?

@robot4jarvis
Copy link
Author

robot4jarvis commented Jan 24, 2021

In this case, I'm only using Lithium, Phosphorus and Sodium. In this particular case, I ran a World Eater to replicate the crash, but it has happened before with only two TNT's.
The game completely freezes and after some minutes Windows tells you that "Java Runtime Environment does not respond".
latest.log
Mega link to the screen recording video: link

The crash happens at around 2:27. You can't see it in the recording but the common "x program doesn't respond" window triggers and Windows asks you whether to close the program or to wait. I waited for some minutes and then I closed it. During the whole process, Java consumes around 45% of the CPU.

@Roan-V
Copy link

Roan-V commented Jan 24, 2021

Have you tried without resource/datapacks?

@robot4jarvis
Copy link
Author

I tried again, without any resource/data packs loaded (only the default one), and using only Phosphorus, Lithium and Sodium.
latest.log
image

@robot4jarvis
Copy link
Author

robot4jarvis commented Jan 24, 2021

I replicated it again, without any resource packs in the "resource packs" folder.
latest.log

F3 Screenshot at the moment of disaster
F3 Screenshot took minutes after it froze.

Thanks for your attention! Besides this bug, your mods are amazing.

@jellysquid3 jellysquid3 changed the title TNT machines crash the game TNT machines deadlock the client Jan 25, 2021
@2No2Name
Copy link
Member

Can you test each mod alone without the other 2 installed? This way we can find out which mod is causing it.

@robot4jarvis
Copy link
Author

I tried each mod alone for about 15 minutes, and it froze while using only Phosphor.
latest.log

@Kroppeb
Copy link

Kroppeb commented Jan 25, 2021

I had a similar issue before with just phosphor when I was continuously generating lighting updates while a lot of lighting updates were already scheduled for that chunk.

@whoImT
Copy link

whoImT commented Jan 25, 2021

can confirm i also have that issue with phosphor

@jellysquid3 jellysquid3 transferred this issue from CaffeineMC/lithium-fabric Jan 25, 2021
@jellysquid3 jellysquid3 reopened this Jan 25, 2021
@jellysquid3 jellysquid3 added 1.16.x bug Something isn't working critical This issue is of critical importance labels Jan 25, 2021
@CaffeineMC CaffeineMC deleted a comment from Kroppeb Jan 25, 2021
@CaffeineMC CaffeineMC deleted a comment from 2No2Name Jan 25, 2021
@CaffeineMC CaffeineMC deleted a comment from robot4jarvis Jan 25, 2021
@whoImT
Copy link

whoImT commented Jan 25, 2021

i've done some testing and afaik the issue only appears in version 0.7.0

@PhiProven
Copy link
Member

I think this is the same as #39 and should hence be fixed by 4c43554.
Feel free to reopen if the issue still occurs with Phosphor 0.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.16.x bug Something isn't working critical This issue is of critical importance
Projects
None yet
Development

No branches or pull requests

7 participants