Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect matrix errors and raise them as exceptions #1

Open
Cadair opened this issue Jul 18, 2021 · 0 comments
Open

Detect matrix errors and raise them as exceptions #1

Cadair opened this issue Jul 18, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Cadair
Copy link
Owner

Cadair commented Jul 18, 2021

Currently if the http request succeeds then we assume the matrix request also succeeded, if an error response is provided from the matrix server we should convert it to a Python exception.

# TODO: Detect matrix errors here
return json.loads(resp.read())

@Cadair Cadair added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant