Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect branch name in validate-schema.yml #326

Open
ElectricNroff opened this issue Jun 19, 2024 · 2 comments
Open

incorrect branch name in validate-schema.yml #326

ElectricNroff opened this issue Jun 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ElectricNroff
Copy link

The master branch name in

branches:
- master
pull_request:
types: [opened, synchronize, reopened]
workflow_dispatch:
branches:
- master

is not compatible with https://github.com/CVEProject/cve-schema/branches

@jayjacobs jayjacobs added the bug Something isn't working label Oct 18, 2024
@jayjacobs
Copy link
Collaborator

Could you expand on why this should be fixed? Is it causing errors anywhere or just if someone read the branches in the schema and looked for that branch in github?
Also, I assume it should just match the "main" branch name?

@ElectricNroff
Copy link
Author

GitHub does not have any documentation indicating that a nonexistent branch name is supported in GitHub Actions. It might currently work for our use case, but stop working later. Related documentation suggests that continuing to use an old branch name, after a rename, does not work in some other aspects of GitHub Actions: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/renaming-a-branch "GitHub Actions workflows do not follow renames"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants