Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotmarker pops on top of day when switching to another month when the standard selected day has a dot programmed on it #59

Closed
martjemeyer opened this issue Apr 27, 2015 · 4 comments

Comments

@martjemeyer
Copy link

When I change from month A to month B, when the autoselected day in the next month has a dot programmed on it, the dot appear on top of that day.
So in the first screenshot, the date selected in the new month is 20, which has no dot programmed on it.
The other screen, the date jumps to the (in this case) today date, which has a dot on it and puts it on top of the day, almost in the box off the day above.
If I set the day to 28's from a previous month, the same effect is generated.

Also, when I return from any popup screen (where I might add something on that day) is there a way to refresh the dot function? So I don't have to scroll to another month and back.

Thanks!

screenshot 2015-04-27 19 35 12
screenshot 2015-04-27 19 35 28

@martjemeyer
Copy link
Author

Ah, I think its because of my implementation.
I set the date with toggleViewWithDate(date) in the ViewDidLoad, since I can set the date in another view .
So when loading the monthView, it gets todays date in the viewDidLoad or a preselected date. If that date appears to have a dot marker installed, the above behaviour appears.
I think that did not happen before.

Also I just noticed, if I do the same for a complete different month than the current month. So if I navigate from my view which only displays one day at the time , I navigate to another month, lets say from may to june and jump to the monthview, the monthView is blank. So again in my viewDidLoad I set the current day with calendarView.toggleViewWithDate(date)..

Is there a better method I should use? So I need to be able to set a date when the monthView loads which I preselected in another view or when a popup closes..

The toggle month to week toggle function works great btw! Really nice job!

screenshot 2015-04-27 20 15 07

@mozharovsky
Copy link
Member

Hello @martjemeyer,

Couldn't you please describe steps I should go in order to reproduce a blank month view appearing?

Thanks in advance,
Eugene

@martjemeyer
Copy link
Author

Hmm I have trouble to reproduce it on your demo app. I'll come back at this tomorrow if I know what happens different.

@martjemeyer
Copy link
Author

I tried everything to reproduce or even deleting all code from the monthviewcontroller, to get to the point where it goes wrong. But no luck. I expect it goes somewhere wrong from my segue to the month viewcontroller and the data I submit. But even that I tried to add to the demo app but still no luck:)

In the end I solved the problem, by switching to the date I want in the viewDidApepar method. Then it also nicely animates. So this one can be closed, since I think doing it the way I do now is even more prettier;)

Thank you for you great work like always!

Regard,

Henk-Martijn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants