Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace hacks #25

Closed
4 tasks
jarhodes314 opened this issue Dec 9, 2020 · 0 comments
Closed
4 tasks

Fix whitespace hacks #25

jarhodes314 opened this issue Dec 9, 2020 · 0 comments
Labels
nice to have This functionality is useful, but non-essential. Should not block the release of the full site.

Comments

@jarhodes314
Copy link
Contributor

Now sveltejs/prettier-plugin-svelte#24 is resolved, we can:

  • Make sure we are using the latest version of prettier-plugin-svelte
  • Remove the nasty regex to replace whitespace in the rollup config
  • Replace the  s and  s with actual whitespace (unless there are any where we have some weird double spacing requirements, but I don't think there are)
  • Fix all the spacing around punctuation (e.g. in the footer, which is where the entire problem began). Possibly a good idea to try and (ab)use the regex in the rollup config as a way of searching for this.
@jarhodes314 jarhodes314 added the nice to have This functionality is useful, but non-essential. Should not block the release of the full site. label Feb 1, 2021
@jarhodes314 jarhodes314 closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have This functionality is useful, but non-essential. Should not block the release of the full site.
Projects
None yet
Development

No branches or pull requests

1 participant