Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing color #717

Closed
WraithKenny opened this issue Oct 17, 2017 · 5 comments
Closed

Missing color #717

WraithKenny opened this issue Oct 17, 2017 · 5 comments

Comments

@WraithKenny
Copy link

The CSS color rebeccapurple is missing.

@toptalo
Copy link

toptalo commented Oct 19, 2017

This color is not described in current specification: CSS Color Module Level 3 [Recommendation]
This color is from future: CSS Color Module Level 4 [Editor’s Draft]

Did not know should we add it today or it will be better to wait while CSS Color Module Level 4 becomes at least a Working Draft.

@WraithKenny
Copy link
Author

I don't know about adopting all of level 4 yet (8-digit hex, new functions, etc.), that'd be up to you, but I think adopting the single new color wouldn't hurt anything, as everyone else has already supported it.

@frvge
Copy link
Contributor

frvge commented Dec 28, 2017

We have to wait for the new version of parser-lib to be released, but besides that it's done thanks to @toptalo .

@frvge frvge closed this as completed Dec 28, 2017
@WraithKenny
Copy link
Author

I think that fixed a few other slightly off colors, but didn't add rebeccapurple tho.

@frvge
Copy link
Contributor

frvge commented Dec 29, 2017

I just merged @toptalo 's new PR with rebeccapurple to parser-lib. You'd have to build your own version of csslint based on parser-lib's master version if you want to use it. Unfortunately I can't do releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants