Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor packages and codebase #45

Closed
qhng opened this issue Oct 14, 2016 · 7 comments
Closed

Refactor packages and codebase #45

qhng opened this issue Oct 14, 2016 · 7 comments
Assignees
@qhng @e0003801
Labels
priority.medium type.task
Milestone
V0.4

Comments

@qhng
Copy link

qhng commented Oct 14, 2016

No description provided.

@qhng qhng added this to the V0.3 milestone Oct 14, 2016
@qhng qhng modified the milestones: V0.4, V0.3 Oct 18, 2016
@qhng qhng self-assigned this Oct 18, 2016
@e0003801
Copy link

What package?

@qhng
Copy link
Author

qhng commented Oct 21, 2016

Settled already. Wait for merge.

@e0003801
Copy link

Refactor Task class to fall under model.task package?

@qhng qhng mentioned this issue Oct 21, 2016
Merged
@qhng
Copy link
Author

qhng commented Oct 21, 2016

All the codes. Including removing unused classes. I have a pending merge.

@e0003801
Copy link

May want to take a look at AddCommand. Should move new Task() from ctor to execute() for consistency.

@qhng
Copy link
Author

qhng commented Oct 21, 2016

Okay. Will do in #72

@qhng
Copy link
Author

qhng commented Oct 21, 2016

Closed. See #71

@qhng qhng closed this as completed Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qhng qhng

@e0003801 e0003801

Labels
priority.medium type.task
Projects
None yet
Milestone
V0.4
Development

No branches or pull requests
2 participants
@qhng @e0003801