Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on the collated code of A0139102U #24

Open
cmkumar87 opened this issue Oct 30, 2016 · 0 comments
Open

Feedback on the collated code of A0139102U #24

cmkumar87 opened this issue Oct 30, 2016 · 0 comments

Comments

@cmkumar87
Copy link

  • you have a lot of SOP lines.
    System.out.println(taskToEditName);
    Are you using them for debugging? If so, try using the actual debugger which can show the variable values at run time; it is much easier to do this way. You can also use a logger to trace runtime logging.
  • Not deleting lines likes this // TODO Auto-generated method stub is bad
  • Unused code commented out.

    //if (!isValidEmail(email)) {

    // throw new IllegalValueException(MESSAGE_EMAIL_CONSTRAINTS);

    //}
  • Not a lot of lines of code for v0.4
  • Don't see any collated test code. Note that this is separately graded.
  • Docs overall team needs to add design diagrams also for newly designed features or parts redesinged. Class and sequence diagrams are the minimum.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant