Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile error in Android #453

Closed
Rey-Wu opened this issue Mar 17, 2023 · 5 comments · Fixed by #461
Closed

Compile error in Android #453

Rey-Wu opened this issue Mar 17, 2023 · 5 comments · Fixed by #461
Assignees
Labels

Comments

@Rey-Wu
Copy link

Rey-Wu commented Mar 17, 2023

I tried to compile it in my android R repository, bu it got a compile error shown:

ld.lld: error: undefined symbol: multiple_files_buffer_init >>> referenced by dlt-daemon.c:1248

Then I tried adding the "src/shared/dlt_multiple_files.c" into srcs of dlt-daemon and libdlt in Android.bp, and it worked for me.

Is this a mistake issue or anything missing in my enviorenment? Thank you!

@sebastienraillet
Copy link
Contributor

Hi @Rey-Wu,
I'm also getting similar issue. This compilation issue has been introduced by PR #369. By reverting it, the issue isn't present anymore.
Your proposal solution sounds good to me 👍

@minminlittleshrimp
Copy link
Collaborator

Hello, I would like to handle this issue!
Thank you

@minminlittleshrimp
Copy link
Collaborator

minminlittleshrimp commented Mar 28, 2023

Hello @sebastienraillet and @Rey-Wu

FYI:
The fix is ready to be merged now with #461
DLT compilation on Android is also smooth with #462

Thank you for bringing the situation to our attention.
DLT team

@lvklevankhanh lvklevankhanh linked a pull request Mar 29, 2023 that will close this issue
@lvklevankhanh
Copy link
Contributor

Hello @sebastienraillet and @Rey-Wu ,
Please verify the fixed #461 is worked at your environments or not?

@Rey-Wu
Copy link
Author

Rey-Wu commented Apr 3, 2023

Hello @lvklevankhanh @minminlittleshrimp ,
Thanks for your fixed, it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants