Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review REQUESTED – L1 DOC TMP Porewater #2

Open
amyerspigg opened this issue Aug 2, 2024 · 3 comments
Open

Review REQUESTED – L1 DOC TMP Porewater #2

amyerspigg opened this issue Aug 2, 2024 · 3 comments
Assignees

Comments

@amyerspigg
Copy link
Collaborator

amyerspigg commented Aug 2, 2024

@stephpenn1 could you please review these "L1" DOC files and let me know if they are at the correct processing level before I put them on Google Drive?

https://github.com/COMPASS-DOE/TEMPEST_Porewater/tree/main/processing_scripts/DOC/TEMPORARY

@amyerspigg amyerspigg changed the title Review REQUESTED Review REQUESTED – L1 DOC TMP Porewater Aug 2, 2024
@stephpenn1
Copy link
Member

Yes sure, when do you need this reviewed by?

@amyerspigg
Copy link
Collaborator Author

@stephpenn1 didn't see your reply! Does in the next two weeks work? I also have the CDOM data ready to review now too. https://github.com/COMPASS-DOE/TEMPEST_Porewater/tree/main/processing_scripts/CDOM/TEMPORARY

Once you review and approved, I'll put in the google drive :)

@stephpenn1
Copy link
Member

Hi! Your datasets look great, I just have a few questions and suggestions:

  • I noticed there aren't any flags, were there any that were applied?
  • In your plot column, I think we are using Saltwater but we'll need confirmation on this (I'll check)
  • My preference for theEvent column would be to change it to site (and lowercase to match the other columns)
  • Any date columns like evacuation_date collection_datetime and tz should be on the left side of the datasets with the other metadata columns
  • I like the standardization of the filenames :-) although they're a little bit inconsistent; for example, instead using
    TMP_PW_GRIDS_NPOC_TDN_2022_L1.csv
    and
    TMP_PW_GRIDS_POOL_Indicies_CDOM_2022_L1.csv
    so that they go SITE_SAMPLETYPE_ORG_ANALYSISTYPE_YEAR_LEVEL.csv thoughts?

Also, let me know if I am not reviewing these datasets in the way you intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants