-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error: 'CV_FUNCTIONAL' was not declared in this scope #23
Comments
Hi @sagitter , We will take a look at the issue. for the meantime could you try to compile it with the bundled sundials please? ... Could you also provide your system info (platform, compiler etc) and copy the cmake log here please? |
Hi @WeiliangChenOIST ,
With bundled sundials (cvode-2.6.0), STEPS is correctly compiled. In Fedora 34+, we're using new sundials-5 files:
|
Dear sagitter, We've checked the code and looks like it requires more implementation changes and testing than simply changing the function call name and inputs. We've added it to our fixing list for the next release and will keep this issue open until then. In the meantime, please use the bundled package instead. |
hi @WeiliangChenOIST , has their been any updates here please, anything we can help with? |
Dear @sanjayankur31, this was left over due to priority issue, we've assigned member to revisit this issue and hopefully provide a fix in the next release. |
Thanks very much. In the meantime, i see that sundials v7 was just released too, so maybe that's worth targeting: https://github.com/LLNL/sundials/releases/tag/v7.0.0 |
We plan to support SUNDIALS library up to version 6 (included) to be compatible with all current Fedora releases |
That'll be great, thank you. (I've not seen a plan to update to 7.x in Fedora yet) |
Dear @sanjayankur31, we have fixed this issue and now support up to Sundials 6.7 in our planned 5.0 release, which is already available on branch https://github.com/CNS-OIST/STEPS/tree/5.0.1 |
Thanks for the quick update @iahepburn . I'll build from that branch and report back ASAP. |
Is there any update from your end, @sanjayankur31 ? Can we close the issue? |
it's still a work in progress I'm afraid. We need to include the sandia-omega-h library in the repos before we can update to 5.x for steps: https://src.fedoraproject.org/rpms/python-steps/pull-request/6 |
I get:
So, quick question: Should this not be in a conditional that checks if MPI is available? https://github.com/CNS-OIST/STEPS/blob/5.0.1/src/steps/geom/dist/CMakeLists.txt#L7 |
Dear @sanjayankur31, thank you for reporting that issue. We have added a more specific error message when attempting to build with the distributed solver but without MPI, as seems to be the case here. If MPI is not available, you can disable the distributed solver with |
dear @sanjayankur31. I was just wondering about this long-standing issue. We see you have omega_h now (https://src.fedoraproject.org/rpms/sandia-omega-h). Have you tried building our latest version, 5.0.3? Let us know if there's anything we can help with. |
Hi @iahepburn , sorry we haven't gotten around to updating STEPS to 5.0.3 Fedora yet. We'll bump it up the backlog and try to get to it in the next couple of weeks. |
I've got a test build going and I can confirm that this is now fixed. I'll clean up the package and push and update to Fedora in the next couple of weeks hopefully: https://src.fedoraproject.org/rpms/python-steps/pull-request/7 |
Hi all.
Please, could you make
STEPS-3.6.0
compatible with recentSundials-5.7.0
(if possible)?:Regards.
The text was updated successfully, but these errors were encountered: