forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anonymous Feature (Sprint #2) - implementing anonymous field in the backend #28
Open
ericlin2
wants to merge
35
commits into
f24
Choose a base branch
from
anonymous-feature
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added anonymous checkbox to the UI
add anonymous field in creation and data fetch (backend)
Anonymous feature - merge to main branch (front & back)
ericlin2
force-pushed
the
anonymous-feature
branch
from
October 9, 2024 17:42
45d1ed0
to
989c51c
Compare
VeronicaPim
force-pushed
the
f24
branch
2 times, most recently
from
October 9, 2024 21:45
bf0fcb8
to
29c75ea
Compare
VeronicaPim
approved these changes
Oct 9, 2024
VeronicaPim
approved these changes
Oct 9, 2024
ericlin2
changed the title
Anonymous Feature - added anonymous to composer data flow
Anonymous Feature (Sprint #2) - added anonymous to composer data flow
Oct 10, 2024
ericlin2
changed the title
Anonymous Feature (Sprint #2) - added anonymous to composer data flow
Anonymous Feature (Sprint #2) - implementing anonymous field in the backend
Oct 10, 2024
eunseokk
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
VeronicaPim
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi please make sure you are checking your code coverage here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend Feature: Implementing the Anonymous Field
Summary
This PR tackles Issue #12, and we attempted to implement a field handling the anonymous nature of a post in the backend, while being connected to the frontend.
Key Changes:
1) Adding anonymous field to frontend post handler function
2) Adding anonymous field to the backend:
3) Adding anonymous field to the schema:
Challenges Encountered:
Current Status:
Build status: The manual lint fixes are in place, and the code should now comply with the project’s coding standards.
Feature status:
Next Steps: Further examination of what functions we implemented our anonymous field triggered the schema errors.
Current status: The anonymous field is included in the post function handling the frontend UI for drafting posts. This field is able to be connected in the backend. Running into issues with having the backend match with the schema right now.
Testing Instructions:
anonymous-feature
branch.