Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WNMGDS-2934] Expand the clean command with clean:builds subcommand #3274

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

pwolfert
Copy link
Contributor

@pwolfert pwolfert commented Oct 11, 2024

Summary

WNMGDS-2934

  • Creates a new yarn clean:builds command that cleans out all the dist folders and the docs public folder (all the build folders for all the build processes)
  • Adds that command to the list of sub-commands executed by yarn clean

How to test

Run it!

Checklist

  • Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

@pwolfert pwolfert added Type: Internal This item relates to internal tooling/maintenance Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. labels Oct 11, 2024
@pwolfert pwolfert added this to the 11.0.1 milestone Oct 11, 2024
Copy link
Collaborator

@tamara-corbalt tamara-corbalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it. Looks good to me!

@pwolfert pwolfert merged commit 3c80380 into main Oct 11, 2024
1 check passed
@pwolfert pwolfert deleted the pwolfert/clean-builds branch October 11, 2024 19:43
@kim-cmsds kim-cmsds modified the milestones: 11.0.1, 11.1.0 Oct 11, 2024
jack-ryan-nava-pbc pushed a commit that referenced this pull request Oct 15, 2024
…nd (#3274)

* Expand the `clean` command with `clean:builds` subcommand

that cleans out all the `dist` folders

* And clean the root `dist` folder too
kim-cmsds pushed a commit that referenced this pull request Oct 17, 2024
…nd (#3274)

* Expand the `clean` command with `clean:builds` subcommand

that cleans out all the `dist` folders

* And clean the root `dist` folder too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. Type: Internal This item relates to internal tooling/maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants