[WNMGDS-2921] Implement Filter Chip Web Component #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh. I created this while logged into my old Github account. Apparently that one still has write access? |
jack-ryan-nava-pbc
added
Impacts: Core
jack-ryan-nava-pbc
requested review from
pwolfert,
kim-cmsds and
tamara-corbalt
packages/design-system/src/components/web-components/ds-filter-chip/ds-filter-chip.tsx
Show resolved
Hide resolved
packages/design-system/src/components/web-components/ds-filter-chip/ds-filter-chip.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Looks great so far!
Noticing a lot of updated snapshots here. Are they the same ones as in pr-3271? If so, would it be cleaner to revert these changes and merge with main once 3271 is merged?"
pwolfert
reviewed
Oct 10, 2024
packages/design-system/src/components/web-components/ds-filter-chip/ds-filter-chip.stories.tsx
Show resolved
Hide resolved
kim-cmsds
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
The filter chip work looks good to me! I would spend a little of time verifying that the snapshot changes are all relevant to work done here to @tamara-corbalt's point.
tamara-corbalt
approved these changes
Oct 14, 2024
This reverts commit 4e4446f.
jack-ryan-nava-pbc
force-pushed
the
jryan/wnmgds-2921-ds-filter-chip
branch
from
38afbaf to
7a4e118
Compare
kim-cmsds
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Initial filter chip code * Initial filter chip tests * Add initial stories * Fix typo and update snapshot * Unit tests are passing * Import tooltip and filter chip * Add small filter chip example to astro * Update cdn-webcomponents example * Hiding controls on multi chip story since they don't seem to work * Revert "Add small filter chip example to astro" This reverts commit 4e4446f. * Change aria-clear-label to clear-label to avoid adding a nonexistent aria label * Whole lotta snapshot updates --------- Co-authored-by: jack-ryan-nava-pbc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ds-filter-chipweb componentHow to test
yarn buildyarn test:unit:wcto confirm that unit tests passyarn storybook& confirm that all attributes are editable in the single filter chip example. I've disabled the props table in the multichip example because the controls didn't do anything.ds-deletecustom event is fired when clicking the chipChecklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.