Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WNMGDS-2821] Fix generating error ids for individual Choices #3146

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

pwolfert
Copy link
Contributor

@pwolfert pwolfert commented Jul 2, 2024

Summary

WNMGDS-2821

Fixes all generated ids for Choice error messages being undefined_error.

How to test

  1. http://localhost:6006/?path=/story/components-choice--default
  2. http://localhost:6006/?path=/docs/web-components-ds-choice--docs

Checklist

  • Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

@pwolfert pwolfert added Type: Fixed Indicates an unexpected problem or unintended behavior Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. labels Jul 2, 2024
@pwolfert pwolfert added this to the 10.1.2 milestone Jul 2, 2024
@pwolfert pwolfert requested a review from zarahzachz July 2, 2024 23:39
@zarahzachz zarahzachz changed the title [NO-TICKET] Fix generating error ids for individual Choices [WNMGDS-2822] Fix generating error ids for individual Choices Jul 3, 2024
Base automatically changed from WNMGDS-2818/prevent-nested-errors-in-choicelist to main July 3, 2024 18:55
@zarahzachz zarahzachz changed the title [WNMGDS-2822] Fix generating error ids for individual Choices [WNMGDS-2821] Fix generating error ids for individual Choices Jul 3, 2024
@pwolfert pwolfert force-pushed the pwolfert/fix-choice-error-id branch from b62748e to 83c0a48 Compare July 3, 2024 18:57
@pwolfert pwolfert merged commit 77840de into main Jul 3, 2024
1 check passed
@pwolfert pwolfert deleted the pwolfert/fix-choice-error-id branch July 3, 2024 20:05
pwolfert added a commit that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. Type: Fixed Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants