[WNMGDS-2762] Fix accordions interfering with keyboard strokes of child elements #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a redundant feature that is getting in the way of forms within accordions.
pwolfert
added
Type: Fixed
zarahzachz
approved these changes
May 1, 2024
pwolfert
added a commit
that referenced
this pull request
May 10, 2024
…ld elements (#3067) Do not allow arrow keys to navigate between accordion items This is a redundant feature that is getting in the way of forms within accordions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WNMGDS-2762
Do not allow arrow keys to navigate between accordion items anymore. This is a redundant feature that is getting in the way of forms within accordions. We talked with an accessibility specialist, and we're okay to just remove that functionality. Users can still tab between the accordion buttons.
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to code:
yarn test:unit:update) and browser-test snapshots (yarn test:browser:update)