[WNMGDS-2725] Add optional analytics tracking to ThirdPartyExternalLink
#3059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(as far as I understand the spec)
This reverts commit adb7113.
pwolfert
added
Impacts: Core
zarahzachz
reviewed
Apr 29, 2024
| "link_url": "foo", | ||
| "parent_component_heading": " ", | ||
| "parent_component_type": " ", | ||
| "text": "External site linkThis link goes to an external site", |
There was a problem hiding this comment.
I noticed the text gets smooshed together here. Is there a chance this data would have an issue?
There was a problem hiding this comment.
Oh, so it's reading the SVG title + whatever the link label is. Instead of textContent, would innerText be a better option? It excludes the info from the SVG, but maybe that's OK?
There was a problem hiding this comment.
Good catch. I'll play around with some of those values
There was a problem hiding this comment.
Oh, I forgot that this is part of the getAnalyticsContentFromRefs function, which is used in a lot of other places. innerText appears to be undefined in a lot of these unit tests too. I think it's actually fine to just leave it.
zarahzachz
approved these changes
Apr 29, 2024
pwolfert
added a commit
that referenced
this pull request
May 10, 2024
…ink` (#3059) * Implement analytics for third party external links (as far as I understand the spec) * Add remaining event properties * Add this analytics config to storybook and prevent extra button engagement event * FOR TESTING IN STORYBOOK * Revert "FOR TESTING IN STORYBOOK" This reverts commit adb7113. * Update doc snapshots * Don't start out with a deprecated prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
thirdPartyExternalLinkSendsAnalyticsconfig property that controls whether theThirdPartyExternalLinksends analytics events by defaultThirdPartyExternalLinkHow to test
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.