Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WNMGDS-2727] Add ds-label component #3034

Merged
merged 3 commits into from
Apr 11, 2024
Merged

[WNMGDS-2727] Add ds-label component #3034

merged 3 commits into from
Apr 11, 2024

Conversation

pwolfert
Copy link
Contributor

Summary

  • Add ds-label component, tests, and docs

Checklist

  • Prefixed the PR title with the Jira ticket number as [WNMGDS-####] Title or [NO-TICKET] if this is unticketed work.
  • Selected appropriate Type (only one) label for this PR, if it is a breaking change, label should only be Type: Breaking
  • Selected appropriate Impacts, multiple can be selected.
  • Selected appropriate release milestone

@pwolfert pwolfert added Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. Type: Added Indicates a new feature. labels Apr 10, 2024
@pwolfert pwolfert added this to the 11.0.0-beta.1 milestone Apr 10, 2024
@pwolfert pwolfert requested a review from zarahzachz April 10, 2024 22:59
@pwolfert pwolfert merged commit 33b4669 into main Apr 11, 2024
1 check passed
@pwolfert pwolfert deleted the pwolfert/ds-label branch April 11, 2024 21:03
@pwolfert pwolfert modified the milestones: 11.0.0-beta.1, 10.1.0 May 3, 2024
pwolfert added a commit that referenced this pull request May 10, 2024
* Add a ds-label with the native `for` attribute!

* Add VRT ref images

* Add storybook-doc snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts: Core Impacts the core DS primarily, changes may occur in other themes as well. Type: Added Indicates a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants