[WNMGDS-2729] Add ds-inline-error web component
#3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwolfert
added
Impacts: Core
pwolfert
changed the base branch from
main
to
pwolfert/storybook-web-component-decorator
zarahzachz
approved these changes
Apr 8, 2024
Base automatically changed from
pwolfert/storybook-web-component-decorator
to
main
April 8, 2024 17:59
pwolfert
force-pushed
the
pwolfert/ds-inline-error
branch
from
4eae8ed to
96856f9
Compare
pwolfert
added a commit
that referenced
this pull request
May 10, 2024
* New `ds-inline-error` and pattern for supplying example text in Storybook * Use the new story decorator * Add VRT ref images * Fix test names and update snapshots * Add storybook-docs snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WNMGDS-2729
ds-inline-errorweb componentcontrolsOnlyarg-type prop to theWebComponentArgsTablefor things we want to have controls for in the stories but not document as acceptable attributes of the web component itself on the doc page.How to test
Check out the new story
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.