[WNMGDS-2697] Update label guidance #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code styles
pwolfert
added
Impacts: Documentation
zarahzachz
approved these changes
Apr 2, 2024
| @@ -4,7 +4,7 @@ title: Forms | |||
|
|
|||
| The design system includes components for the standard HTML form elements: [checkboxes](/components/checkbox/) and [radio buttons](/components/radio/), [text fields](/components/text-field/), [dropdowns ](/components/dropdown/), fieldsets, labels, and so on. | |||
|
|
|||
| Below are some best practices your project should aim to follow in order to provide the most accessible and usable experience for your users. Additional guidance, specific to each form field, is provided in each component's guidance tab. | |||
| Below are some best practices your project should follow in order to provide the most accessible and usable experience for your users. Additional guidance, specific to each form field, is provided in each component's guidance tab. | |||
There was a problem hiding this comment.
Just curious - what's a "guidance tab"? Is this referring to the guidance sections we have?
There was a problem hiding this comment.
Huh, I wonder if that was borrowed. I didn't notice that
There was a problem hiding this comment.
Oh, it was there originally. Must have been a time when the doc site was structured differently
pwolfert
added a commit
that referenced
this pull request
May 10, 2024
* Update label guidance according to content team directions * Get rid of extra little space * Looks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code stylesLooks better without putting these in code styles * There are no guidance "tabs" * Update guidance after talking through Sarah's feedback with content team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WNMGDS-2697
Label guidance was outdated, so we requested they be rewritten by the content team. Here are the updates.
How to test
Take a look at the affected pages on the doc site.
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to documentation: