-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WNMGDS-2667][WNMGDS-2668] Scripts for syncing tokens with Figma #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarahzachz
approved these changes
Feb 21, 2024
Also decided to keep the file naming conventions with the original code from Figma
(Even though we know it won't work without Figma Enterprise access)
c59385f
to
26edea7
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Impacts: Core
Impacts the core DS primarily, changes may occur in other themes as well.
Type: Internal
This item relates to internal tooling/maintenance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WNMGDS-2667, WNMGDS-2668
Add scripts for syncing from and to Figma. This code actually assumes that we're changing the way we store our tokens. These scripts to not interact with our existing token data stored in TypeScript files. We've been updating the structure and values of the tokens in Figma itself, and we will be syncing down from Figma to get our new source of truth, and we will then be storing those tokens in the draft standard for token json.
How to test
There are some unit tests that can be run, but we won't be able to fully test the executable scripts until we have access to enterprise Figma.
Checklist
[WNMGDS-####] Title
or [NO-TICKET] if this is unticketed work.Type
(only one) label for this PR, if it is a breaking change, label should only beType: Breaking
Impacts
, multiple can be selected.