[WNMGDS-2667] Separate color utils into their own module and add to them #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We reference these utils in several places, and we'll be adding figma syncing modules to that list, and they don't need the other utils that aren't related to color
pwolfert
added
Type: Internal
zarahzachz
approved these changes
Feb 21, 2024
| } | ||
|
|
||
| export function rgbToHex({ r, g, b, a }: RgbaObject) { | ||
| if (a === undefined) { |
There was a problem hiding this comment.
could you remove this conditional by setting a default value in the argument? export function rgbToHex({ r, g, b, a = 1 }: RgbaObject) {}
There was a problem hiding this comment.
Yeah, that's a good change. This came verbatim from Figma's example project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WNMGDS-2667
I've separated these changes to make the next PRs less noisy. The color utils are generally useful by many different modules, but the other utils in this file were specific to the token export. I'm separating color utils into their own module and adding some things that will be used by our Figma-syncing code.
How to test
Should be able to do all the token stuff and build the doc site without any problems.
Checklist
[WNMGDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.