-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WNMGDS-2439] Replace many config functions with single global config
function
#2889
Conversation
Introduce the new JavaScript config interface [defined in our RFC](#2435) alongside our old way of setting feature flags
I'm thinking I might have another analytics setting to add to the config, and then maybe the analytics docs can all live in one place
And fix an inaccuracy in one of the doc comments
// Deprecated stuff | ||
|
||
function depWarning(fnName: string) { | ||
if (process.env.NODE_ENV !== 'production') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if these errors are best seen when the env is dev? do we want to litter the console in prod with these warnings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's targetting non-production. Did you find it working otherwise through testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I misread the code. Disregard!
Summary
WNMGDS-2439
Introduces the new JavaScript config interface defined in our RFC alongside our old way of setting feature flags, which are now deprecated.
From the RFC:
config
function to rule them all (one function to bind them...)How to test
Checklist
[WNMGDS-####] Title
or [NO-TICKET] if this is unticketed work.Type
(only one) label for this PR, if it is a breaking change, label should only beType: Breaking
Impacts
, multiple can be selected.If this is a change to code:
yarn test:unit:update
) and browser-test snapshots (yarn test:browser:update
)If this is a change to documentation: