Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Implementation in Header Files #4

Open
atishelmanch opened this issue Dec 16, 2020 · 0 comments
Open

Function Implementation in Header Files #4

atishelmanch opened this issue Dec 16, 2020 · 0 comments

Comments

@atishelmanch
Copy link

atishelmanch commented Dec 16, 2020

Is there a reason that for many classes, both the header and cc files are used to define and implement functions? If not, it would probably make more sense to define the functions in the header files and implement them in the cc files.

For example, the EcalFenixStrip class [.h] [.cc]

[.h] https://github.com/CMS-ECAL-Trigger-Group/SimCalorimetry/blob/Odd-Weights-Filter-Dev/EcalTrigPrimAlgos/interface/EcalFenixStrip.h
[.cc] https://github.com/CMS-ECAL-Trigger-Group/SimCalorimetry/blob/Odd-Weights-Filter-Dev/EcalTrigPrimAlgos/src/EcalFenixStrip.cc

Also, for the EcalTrigPrimFunctionAlgo class, it almost appears that the roles of the header and cc files are swapped. Is there a reason for this?

@atishelmanch atishelmanch changed the title Heavy Use of Header File Functions Function Implementation in Header Files Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant