date_format parameter not applied to non-timestamp based date inputs.

[tw2113]

Looks like date_format is only ever applied inside of text_date_timestamp(). I would assume we want it to be applicable to text_time and text_date, but I'll leave it up to your discretion

[danielmilner]

It appears that text_date honors the date_format, but only when you edit and re-save the record. It may be that the date picker is not honoring the date_format.

[yivi]

I can confirm that something goes weird regarding 'date_format'.

This code:

$main->add_field(
        [
            'name'        => __( 'Fecha', 'ojiva-plugin' ),
            'id'          => $prefix . 'fecha_realizacion',
            'type'        => 'text_date',
            'date_format' => 'd-m-Y'
        ]
    );

Produces this:

[tacone]

That's precisely what happens to me, the format is applied to the textbox, but not to the datepicker.

[tacone]

My current workaround:

$('.cmb2-datepicker').focus(function () {
        var val = $(this).val();
        $(this).datepicker("option", "dateFormat", "dd/mm/yy");
        $(this).val(val);
});

[yivi]

@tacone, I have working fix in #446.
You can checkout my fork at https://github.com/yivi/CMB2, which fixes all these problems. If you can test it out to confirm things are working as expected, it would be nice.

Hopefully at some point we can finish integrating my PR into the main project.

Regards.

[tacone]

I can't test right now, as I'm a under a tight deadline, will surely do in the next project.

Thank you for now.

[jtsternberg]

This should be good in trunk. Huge thanks for @yivi's work. Please test.

[tnorthcutt]

Closing as this looks resolved; @jtsternberg please reverse if I'm wrong 😄