Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper handling of event_name attribute in Hazard and Impact #910

Closed
peanutfun opened this issue Jul 8, 2024 · 2 comments · Fixed by #951
Closed

Ensure proper handling of event_name attribute in Hazard and Impact #910

peanutfun opened this issue Jul 8, 2024 · 2 comments · Fixed by #951
Assignees
Labels
accepting pull request Contribute by raising a pull request to resolve this issue! enhancement

Comments

@peanutfun
Copy link
Member

Is your feature request related to a problem? Please describe.
The documentation of Hazard and Impact states that the event_name attribute is supposed to be a list of strings. However, this is never enforced within the code base. In particular, some unit tests actually check if "mixed-type" lists work. In #894, we decided that

  • a write method should not proceed if event_name contains other values than strings
  • a read method should warn if event_name is not stored as strings and try to convert the values to strings.

Describe the solution you'd like
Apply the above decisions to all readers and writers of Hazard and Impact.

Describe alternatives you've considered

Additional context
None

@peanutfun
Copy link
Member Author

Impact tests with mixed-type event name values: #894 (comment)

@peanutfun peanutfun added the accepting pull request Contribute by raising a pull request to resolve this issue! label Jul 8, 2024
@peanutfun peanutfun changed the title Ensure proper handling of event_name attribute in Hazard and Impact. Ensure proper handling of event_name attribute in Hazard and Impact Jul 9, 2024
@spjuhel spjuhel self-assigned this Aug 22, 2024
@spjuhel spjuhel closed this as completed Mar 3, 2025
@spjuhel
Copy link
Collaborator

spjuhel commented Mar 3, 2025

Closed with #951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting pull request Contribute by raising a pull request to resolve this issue! enhancement
Projects
None yet
2 participants