Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade pandas 1.5 -> 2.0 #700

Closed
emanuel-schmid opened this issue Apr 19, 2023 · 4 comments
Closed

upgrade pandas 1.5 -> 2.0 #700

emanuel-schmid opened this issue Apr 19, 2023 · 4 comments

Comments

@emanuel-schmid
Copy link
Collaborator

append and iteritems are no longer methods of pandas DataFrame.

Failing Tests:

  • climada.engine.unsequa.test.test_unsequa.TestCalcCostBenefit.test_calc_sensitivity_pass
  • climada.engine.unsequa.test.test_unsequa.TestCalcCostBenefit.test_calc_uncertainty_pass
  • climada.engine.unsequa.test.test_unsequa.TestCalcCostBenefit.test_calc_uncertainty_pool_pass
  • climada.engine.unsequa.test.test_unsequa.TestCalcImpact.test_calc_sensitivity_morris_pass
  • climada.engine.unsequa.test.test_unsequa.TestCalcImpact.test_calc_sensitivity_pass
  • climada.engine.unsequa.test.test_unsequa.TestOutput.test_plot_unc_imp
  • climada.engine.unsequa.test.test_unsequa.TestOutput.test_save_load_pass
  • climada.util.test.test_lines_polys_handler.TestGeomImpactCalcs.test_calc_geom_impact_mixed
  • climada.util.test.test_lines_polys_handler.TestGeomImpactCalcs.test_impact_pnt_agg
@chahank
Copy link
Member

chahank commented Apr 19, 2023

iteritems must apparently be replaced with items and append with pd.concat.

@ThomasRoosli
Copy link
Collaborator

Another possible stopper for the update is apparently the pandas.Series.resample()/pandas.DataFrame.resample()/pandas.Grouper methodologies that no longer accepts the deprecated parameter base.
This could be another reason for some of the failing tests.

@chahank
Copy link
Member

chahank commented Aug 29, 2023

All the unsequa tests are now passing after merging of PR #763 .

@chahank
Copy link
Member

chahank commented Aug 30, 2023

For the other two tests #777 should have solved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants