Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retries on ingest_upload errors #13

Open
curlup opened this issue Aug 5, 2019 · 0 comments
Open

Retries on ingest_upload errors #13

curlup opened this issue Aug 5, 2019 · 0 comments

Comments

@curlup
Copy link
Member

curlup commented Aug 5, 2019

By default

On rare occasions, a function might exit prematurely due to an internal error, and by default the function might or might not be automatically retried.

More typically, a background function may fail to successfully complete due to errors thrown in the function code itself. 

I suggest we add retry to the deployment:

script: bash deploy/pubsub.sh ingest_upload uploads .env.staging.yaml
on:
branch: master
- provider: script
script: bash deploy/pubsub.sh ingest_upload uploads .env.prod.yaml

Here are best practices on retries:
https://cloud.google.com/functions/docs/bestpractices/retries#functions-tips-infinite-retries-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant