Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namelist defaults and documentation #441

Closed
eclare108213 opened this issue May 12, 2020 · 5 comments
Closed

namelist defaults and documentation #441

eclare108213 opened this issue May 12, 2020 · 5 comments

Comments

@eclare108213
Copy link
Contributor

Clarify or fix this confusing issue: ‘default’ namelist values in the documentation do not necessarily match those in the default namelist file because the documented default namelist values are suggested for production runs, and with our greatly expanded tests, more than one value is often tested. We need to define what we mean by "default," e.g. whether they are values set in the main ice_in file, or in the production namelist option, or the code's last resort when all other options are exhausted. I think we have a mix of these now.

@eclare108213
Copy link
Contributor Author

#390 is related to this, I think

@apcraig
Copy link
Contributor

apcraig commented May 14, 2020

I think the documented defaults should be the values defined within the code. They can, of course, be changed in namelist. If there is a different recommendation for production runs, then we should document that as a separate column in the namelist table or via some other process.

@apcraig
Copy link
Contributor

apcraig commented Jun 3, 2020

I am working on this now. In CICE, we have a column in the namelist table called "recommended value". I propose to change this to "default value" and then update the values to indicate the default value within the CICE code (which can/will be overidden by namelist). Do we want another column indicated "recommended value" or "production recommendation" or something? I think it's important to document the internal default, not sure about anything else. Unless someone disagrees, I'll proceed with this approach.

@eclare108213
Copy link
Contributor Author

It makes sense to document the values defined in the code, in case a namelist value is not set. I think that 'recommended value' is more useful, however that value might not be the best one for all configurations. This is a tricky issue. Optimally, we'd document various values used in various configurations, with citations to relevant papers, but that's a lot of work (so let's not, unless someone has already done it and it's handy). Alternatively, we could add a footnote or a comment to the table that points to the gx1 production -s option, and explain that those were the recommended values for stand-alone configurations in v5, which depended somewhat on the forcing data used at that time (and cite relevant papers if appropriate).

@apcraig
Copy link
Contributor

apcraig commented Jun 7, 2020

#459 addressed this issue. internal code defaults are now documented in the namelist tables. we may need to add a new section to the documentation, "model configuration recommendations". if so, we should create a new issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants