-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hook CGAL_hook_fix_ctest_dependencies #8003
Add a hook CGAL_hook_fix_ctest_dependencies #8003
Conversation
This hook fonction detects dependencies between compilation tests.
Actually, this could be a bug fix for release branches as well, but the patch is quite heavy. @sloriot Do you want to fix the CMake issues in the testsuite for release branches as well? |
It does not seem necessary to me. |
Windows does not seem to like this change. See 6.0-Ic-168 |
Indeed. There is a mapping from "target" to "compilation tests" in CGAL, but with MSVC. I will have to amend the logic. |
Should be fixed by 3664fc8. I have not tested on Windows. I have only test on Linux that there was no regression. |
Successfully tested in CGAL-6.0-Ic-169 |
Summary of Changes
Add a hook
CGAL_hook_fix_ctest_dependencies
.This hook function detects dependencies between targets tests, and add proper dependencies between compilation tests of those targets.
Release Management