Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hook CGAL_hook_fix_ctest_dependencies #8003

Merged

Conversation

lrineau
Copy link
Member

@lrineau lrineau commented Jan 26, 2024

Summary of Changes

Add a hook CGAL_hook_fix_ctest_dependencies.

This hook function detects dependencies between targets tests, and add proper dependencies between compilation tests of those targets.

Release Management

  • Affected package(s): Installation, Polyhedron/demo

This hook fonction detects dependencies between compilation tests.
@lrineau
Copy link
Member Author

lrineau commented Jan 26, 2024

Actually, this could be a bug fix for release branches as well, but the patch is quite heavy.

@sloriot Do you want to fix the CMake issues in the testsuite for release branches as well?

@sloriot
Copy link
Member

sloriot commented Jan 26, 2024

Actually, this could be a bug fix for release branches as well, but the patch is quite heavy.

@sloriot Do you want to fix the CMake issues in the testsuite for release branches as well?

It does not seem necessary to me.

@sloriot
Copy link
Member

sloriot commented Feb 8, 2024

Windows does not seem to like this change. See 6.0-Ic-168

@lrineau
Copy link
Member Author

lrineau commented Feb 8, 2024

Windows does not seem to like this change. See 6.0-Ic-168

Indeed. There is a mapping from "target" to "compilation tests" in CGAL, but with MSVC. I will have to amend the logic.

@lrineau
Copy link
Member Author

lrineau commented Feb 8, 2024

Windows does not seem to like this change. See 6.0-Ic-168

Should be fixed by 3664fc8. I have not tested on Windows. I have only test on Linux that there was no regression.

@sloriot
Copy link
Member

sloriot commented Feb 13, 2024

Successfully tested in CGAL-6.0-Ic-169

@lrineau lrineau added the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Feb 13, 2024
@lrineau lrineau merged commit 3b4d0cf into CGAL:master Feb 13, 2024
9 checks passed
@lrineau lrineau removed the rm only: ready for master For the release team only: that indicates that a PR is about to be merged in 'master' label Feb 13, 2024
@lrineau lrineau deleted the Polyhedron_demo-fix_CTest_dependencies-GF branch February 13, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants