Aos_2: bug-fix for arrangements of geodesic arcs on a sphere #7644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersection point. Perhaps, a similar fix is required for validity of overlapping intersections
Comment on lines
102
to
103
| /*! Obtain the location of the point. | ||
| */ |
There was a problem hiding this comment.
location or location type?
|
New warnings in CGAL-6.0-Ic--42
There might be more, but I only spotted those 2 while having a quick look. |
sloriot
added
Bug
Pkg::Arrangement_on_surface_2
Tests failing (warning)
Batch_1
|
"location type" indeed; fixed.
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Fri, 11 Aug 2023 at 12:01, albert-github ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
Arrangement_on_surface_2/include/CGAL/Arr_geodesic_arc_on_sphere_traits_2.h
<#7644 (comment)>:
> + /*! Obtain the location of the point.
+ */
location or location type?
—
Reply to this email directly, view it on GitHub
<#7644 (review)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOFFHVQROVG6KIA7ER3XUXYFNANCNFSM6AAAAAA3L5GAEI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
… that approximate a curve; in particular, respected the l2r parameter.
|
Fixed.
Also added a note to CHANGES.md
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Thu, 17 Aug 2023 at 10:09, Sebastien Loriot ***@***.***> wrote:
New warnings in CGAL-6.0-Ic--42
- CGAL/Arr_geodesic_arc_on_sphere_traits_2.h:2891:55: warning: unused
parameter 'l2r' [-Wunused-parameter]
- /mnt/testsuite/include/CGAL/Arrangement_2/Arrangement_zone_2_impl.h:584:8:
warning: variable 'equal' set but not used [-Wunused-but-set-variable]
There might be more, but I only spotted those 2 while having a quick look.
—
Reply to this email directly, view it on GitHub
<#7644 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOCN4GQXERB4FQPYKITXVW7RHANCNFSM6AAAAAA3L5GAEI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sloriot
added
Under Testing
Conflicts
and removed
Tests failing (warning)
Under Testing
labels
|
Could you please fix the conflicts with master? |
|
Merged with master
____ _ ____ _
/_____/_) o /__________ __ //
(____ ( ( ( (_/ (_/-(-'_(/
_/
…On Mon, 21 Aug 2023 at 14:31, Sebastien Loriot ***@***.***> wrote:
Could you please fix the conflicts with master?
—
Reply to this email directly, view it on GitHub
<#7644 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVBNOATF7ES6OM6B7N5YL3XWNBHPANCNFSM6AAAAAA3L5GAEI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
lrineau
changed the title
|
Resolved |
|
Successfully tested in CGAL-6.0-Ic-64 |
lrineau
added
the
rm only: ready for master
lrineau
removed
the
rm only: ready for master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixed a bug in the zone construction code applied to arrangements of geodesic arcs on a sphere, when inserting an arc that lies on the identification curve.
I seized the opportunity and added support for simple drawing of arrangements of geodesic arcs on a sphere. (I added it to ease the debugging...)
Release Management