Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrangement_2: Error in draw_arr.cpp #7562

Closed
afabri opened this issue Jun 29, 2023 · 1 comment · Fixed by #7397
Closed

Arrangement_2: Error in draw_arr.cpp #7562

afabri opened this issue Jun 29, 2023 · 1 comment · Fixed by #7397
Assignees
@efifogel
Labels
Bug Pkg::Arrangement_on_surface_2
Milestone
6.0-beta

Comments

@afabri
Copy link
Member

afabri commented Jun 29, 2023

Issue Details

CGAL::IO::Color does not have a constructor with floats for rgb. The example draw_arr.cpp is buggy here.

It is probably a bad idea to add a constructor, as when I pass numbers to the constructor this may be ambiguous.

Environment

  • CGAL version: master
@afabri
Copy link
Member Author

afabri commented Jun 29, 2023 •
edited
Loading

There is a fix on the way. See c3b7214

@lrineau lrineau linked a pull request Jun 30, 2023 that will close this issue
CGAL: Qt5 -> Qt6 #7397
Merged
4 tasks
@lrineau lrineau added this to the 6.0-beta milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efifogel efifogel

Labels
Bug Pkg::Arrangement_on_surface_2
Projects
None yet
Milestone
6.0-beta
Development

Successfully merging a pull request may close this issue.

CGAL: Qt5 -> Qt6 afabri/cgal
3 participants
@afabri @lrineau @efifogel