Fixed approximation of arcs with theta>PI: atan2 was returning negati…

…ve value, so I added 2*PI to make it in the range [0,2*PI)
CGAL · May 30, 2023 · 01e6057 · 01e6057
1 parent 910e043
commit 01e6057
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/Arrangement_on_surface_2/include/CGAL/Arr_geodesic_arc_on_sphere_traits_2.h b/Arrangement_on_surface_2/include/CGAL/Arr_geodesic_arc_on_sphere_traits_2.h
@@ -2984,6 +2984,8 @@ class Arr_geodesic_arc_on_sphere_traits_2 : public Kernel_ {
             auto ltx = CGAL::scalar_product(axisX, vt);
             auto lty = CGAL::scalar_product(axisY, vt);
             theta = std::atan2(lty, ltx);
+            if (theta < 0)
+                theta += 2.0 * CGAL_PI;
         }
 
         // compute the number of divisions given the error