Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a filename convention in profiles #600

Merged
merged 10 commits into from
Aug 2, 2021
Merged

Introduce a filename convention in profiles #600

merged 10 commits into from
Aug 2, 2021

Conversation

catsuryuu
Copy link
Contributor

No description provided.

@catsuryuu catsuryuu requested a review from chivay July 30, 2021 03:10
chivay
chivay reviewed Jul 30, 2021
View reviewed changes
Copy link
Collaborator

@chivay chivay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, if we're adding x86_ prefix, why not do the same with x64_ or amd64_ ?

@chivay chivay requested a review from a team August 2, 2021 16:00
catsuryuu
catsuryuu commented Aug 2, 2021
View reviewed changes
drakrun/drakrun/drakpdb.py Outdated Show resolved Hide resolved
@chivay chivay merged commit 46293b5 into master Aug 2, 2021
@chivay chivay deleted the filename-convention-in-profiles branch August 2, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chivay chivay chivay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catsuryuu @chivay