apply new, more generic analysis format #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kscieslinski
changed the title
chivay
requested changes
Apr 27, 2021
There was a problem hiding this comment.
What's the state of other karton systems that rely on current dumps format?
This is a breaking change so we should be very careful.
Moreover, this PR should also address:
https://github.com/CERT-Polska/drakvuf-sandbox/blob/master/drakrun/drakrun/regression.py#L75-L88
|
Thanks for linking the regression tester – I've missed that! Regarding other karton systems that rely on current dumps format I'm currently only adding additional information and I'm not removing anything at this stage, so it should be fine. |
|
Oh, OK. I somehow misread that now we're putting only dumps into dumps.zip without metadata |
chivay
approved these changes
Apr 28, 2021
icedevml
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
dumps_metadataso that Karton instances that process analysis won't need to rely on the filename format of the memory dumps. I've also changed the bindings and task headers ofkarton.drakrun-prodandkarton.drakrun.processor.