Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail: Error: Symbol 'source_dir' at (1) has no IMPLICIT type #1705

Open
yurivict opened this issue Oct 24, 2024 · 7 comments
Open

tests fail: Error: Symbol 'source_dir' at (1) has no IMPLICIT type #1705

yurivict opened this issue Oct 24, 2024 · 7 comments

Comments

@yurivict
Copy link

Tests run for while until this happens:

ok 1 - 
      LINK.F build/t400-qfunction-f
/usr/ports/math/libceed/work/libCEED-0.12.0/tests/t400-qfunction-f.f90:30:16:

   30 |      &SOURCE_DIR&
      |                1
Error: Symbol 'source_dir' at (1) has no IMPLICIT type
gmake: *** [Makefile:571: build/t400-qfunction-f] Error 1
*** Error code 1

Version: 0.12.0
gfortran13
FreeBSD 14.1

@jeremylt
Copy link
Member

jeremylt commented Oct 24, 2024

Can you share your compiler options?

Note - I recommend using the latest main branch instead of v0.12

Also, do you specifically need the Fortran interface?

@yurivict
Copy link
Author

CFLAGS=-O2 -pipe -fPIC -fstack-protector-strong -fno-strict-aliasing

@yurivict
Copy link
Author

Also, do you specifically need the Fortran interface?

I am going to create the FreeBSD port so yes, Fortran interface is desirable.

@yurivict
Copy link
Author

The current master revision e3ae47f fails in a different way:

ok 1 - 
      LINK.c build/t406-qfunction
In file included from /usr/ports/math/libceed/work/libCEED-0.12.0-763-ge3ae47f6/tests/t406-qfunction.c:4:
/usr/ports/math/libceed/work/libCEED-0.12.0-763-ge3ae47f6/tests/t406-qfunction.h:22:10: fatal error: '../../libCEED/tests/t406-qfunction-helper.h' file not found
   22 | #include "../../libCEED/tests/t406-qfunction-helper.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
$ find . -name t406-qfunction-helper.h
./work/libCEED-0.12.0-763-ge3ae47f6/tests/t406-qfunction-helper.h

@jeremylt
Copy link
Member

jeremylt commented Oct 24, 2024

Our Fortran interface currently has zero users, but it's tested in CI on MacOS and Ubuntu environments. If there are users who actually use it, it might need some work to make it a bit more modern.

Did you have any Fortran compiler options, since it's the Fortran compiler that failed? (Well, the Fortran linker maybe?)

@jeremylt
Copy link
Member

jeremylt commented Oct 24, 2024

Hmm, I'm suspicious that the Fortran compiler is not correctly supplying the source directory path to the macro above on the first.

That second is odd because that header is sitting right next to the .c file

I'm not an expert, but initial Googleing seems to indicate that file paths work differently sometimes on BSD vs other systems?

@yurivict
Copy link
Author

FFLAGS=-O -Wl,-rpath=/usr/local/lib/gcc13
FCFLAGS=-Wl,-rpath=/usr/local/lib/gcc13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants