Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sentSubmissionId and receivedSubmissionId to inboundMessageId and outboundMessageId #1404

Open
10 of 11 tasks
basiliskus opened this issue Oct 9, 2024 · 0 comments
Open
10 of 11 tasks

Rename sentSubmissionId and receivedSubmissionId to inboundMessageId and outboundMessageId #1404

basiliskus opened this issue Oct 9, 2024 · 0 comments
Assignees
@pluckyswan
Labels
devex/opex A development excellence or operational excellence backlog item. Stream 1

Comments

@basiliskus
Copy link
Contributor

basiliskus commented Oct 9, 2024 •
edited by pluckyswan
Loading

DevEx/OpEx

High level description of what what needs to be improved.

Tasks

  • Rename sentSubmissionId to outboundReportId
    • Rename tests
    • Rename variables
    • Rename functions
  • Rename receivedSubmissionId to inboundReportId
    • Rename tests
    • Rename variables
    • Rename functions
  • Add comment clarifying recordId is actual a reportId
  • Possibly add an ADR or clarifying comments on first instance of variables
  • Confirm cleanup

Additional Context

https://flexion.slack.com/archives/C055XTF22B0/p1704911117020269
@basiliskus basiliskus added the devex/opex A development excellence or operational excellence backlog item. label Oct 9, 2024
@pluckyswan pluckyswan self-assigned this Nov 19, 2024
This was referenced Nov 19, 2024
Closed
Draft
@GilmoreA6 GilmoreA6 mentioned this issue Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pluckyswan pluckyswan

Labels
devex/opex A development excellence or operational excellence backlog item. Stream 1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@basiliskus @pluckyswan