Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize model directories #101

Closed
damonbayer opened this issue Nov 4, 2024 · 7 comments
Closed

Reorganize model directories #101

damonbayer opened this issue Nov 4, 2024 · 7 comments

Comments

@damonbayer
Copy link
Collaborator

damonbayer commented Nov 4, 2024

This issue refers to the location-level directories. These currently contain a flat list of poorly named files. This is already difficult to navigate and will be increasingly so as we add more fable models and pyrenew models.
I propose having a common data and figures directory and a separate directory for each model's specific output.

  • data
  • pyrenew-e
  • pyrenew-ew
  • fable
  • figures
@SamuelBrand1
Copy link
Collaborator

For clarification... this is a reorganistion within each of the model definition folders?

@SamuelBrand1
Copy link
Collaborator

Assuming the above is true, I think the simplest sequence is to do #119 (or some other PR that closes #57) then reorg the internal structure of each location-reportdate directory.

@damonbayer
Copy link
Collaborator Author

Started working on this, (see edited original post) but got a bit lost. I think it would be helpful to first develop a data dictionary-like resource about what these files are and what they contain.

@damonbayer
Copy link
Collaborator Author

I'm wondering if we should actually put everything here in a pyrenew-e directory.

@damonbayer
Copy link
Collaborator Author

I'm wondering if we should actually put everything here in a pyrenew-e directory.

@dylanhmorris has endorsed separate directories for each model (e.g. PyRenew-E, PyRenew-HE) with the Batch/State directories.

@damonbayer
Copy link
Collaborator Author

Updated the initial post with my current thinking.

@damonbayer
Copy link
Collaborator Author

This was done in #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants