Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update bulk uploader datetime validations #8253

Open
emyl3 opened this issue Oct 30, 2024 · 4 comments
Open

[BUG] Update bulk uploader datetime validations #8253

emyl3 opened this issue Oct 30, 2024 · 4 comments
Assignees
Labels

Comments

@emyl3
Copy link
Collaborator

emyl3 commented Oct 30, 2024

Description

  • Discovered while working on Support timezones for Puerto Rico #8225
  • The results bulk uploader date time validation can be updated to address the following scenarios:
    • extra whitespace (e.g. "10/18/2024 10:00" - passes but with extra whitespaces it fails)
    • Currently it does not handle AM or PM abbreviations
      • Open question: Do we want to support this or only 24H time?

Verify that the documentation makes the intended format clear.

Steps to reproduce

Steps here

  • use the csv in the comment above

Expected behavior

  • TBD

Additional context

  • N/A
@emyl3 emyl3 changed the title [BUG] Update the bulk uploader datetime validations [BUG] Update bulk uploader datetime validations Oct 30, 2024
@mindyatwork
Copy link
Collaborator

mindyatwork commented Jan 23, 2025

Please address the whitespace issue.

If handling the AM/PM abbreviation is a ~1-2 point lift, please address that too. If more than that, we should investigate from the logs if users commonly run into this error.

@arinkulshi-skylight
Copy link
Collaborator

@jayna-SkylightDigital a quick question on this ticket. Is there a max number of white spaces the user is allowed to input here? For example:
01/01/ 2023 11:11 PT might be a challenge for our parser to be able to process.

@jayna-SkylightDigital
Copy link
Collaborator

@jayna-SkylightDigital a quick question on this ticket. Is there a max number of white spaces the user is allowed to input here? For example: 01/01/ 2023 11:11 PT might be a challenge for our parser to be able to process.

@arinkulshi-skylight I ran this by the team, and @DanielSass's recommendation is that additional spaces included in dates would result in an error:

if people are putting extra spaces in the middle of their date times, that’s not the api and that should be an error in my opinion.

@DanielSass
Copy link
Collaborator

Moving back to Needs requirements until Mindy is back in office. I misunderstood the behavior being described and I don't think it constitutes a bug. Want to make sure we're all on the same page before we close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants