Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manage users - User information] Forms do not use proper element and error handling needs improvement #5828

Closed
johanna-skylight opened this issue May 17, 2023 · 0 comments · Fixed by #5941
Assignees
Labels
Accessibility Issues that affect SR's accessibility

Comments

@johanna-skylight
Copy link
Contributor

Area or Component

Settings Page -> Manage users Tab -> User information

Quick Summary

The forms to edit name, edit email are not using the proper html tag to wrap the form and the submission pattern does not show errors on submit.

How to Replicate

Check the edit name and edit email form and try to submit incorrect/invalid information.

Action Requested

Change the div element that wraps the form with a form tag.
Implement the pattern to show error on submission (including focus on error).
Stretch use react-hook-forms to implement the error handling.

Screenshots (optional)

Screenshot 2023-05-17 at 10 05 50 AM
Screenshot 2023-05-17 at 10 05 41 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Issues that affect SR's accessibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants