Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTE.1 is blank #3725

Closed
rhood23699 opened this issue Jan 7, 2022 · 6 comments
Closed

NTE.1 is blank #3725

rhood23699 opened this issue Jan 7, 2022 · 6 comments
Assignees
Labels
bug Issue Type label to flag an issue that is a bug High Priority Issue State label to flag an issue that is a high priority

Comments

@rhood23699
Copy link
Contributor

rhood23699 commented Jan 7, 2022

Problem statement

I added a "comment" column to the standard CSV schema. The NTE segment is being created, but as shown below, the NTE.1 doesn't have a Set ID.

NTE||L^Ancillary (filler) department is source of comment^HL70105|Test Comment|RE^Remark^HL70364^^^^2.5.1

What you need to know

For testing, use the branch "OO/StdCSVSchema-Modifications Based on Testing". Attached is a test.

StandardCSV-Test.csv

Acceptance criteria

Each NTE.1 segment is sequentially numbered starting with 1.

@rhood23699 rhood23699 added bug Issue Type label to flag an issue that is a bug pipeline Cle, Jim, Yemi, Carlos, Gage, Derek, Ott labels Jan 7, 2022
@rhood23699 rhood23699 added the High Priority Issue State label to flag an issue that is a high priority label Jan 7, 2022
@rhood23699
Copy link
Contributor Author

Note, I marked this is a high priority. The Experience Team is moving quickly to add new Senders to the Standard CSV Upload, so this problem may appear soon than later.

@oslynn
Copy link
Collaborator

oslynn commented Jan 8, 2022

Rick Hood, would you please give steps to reproduce the bug?

@rhood23699
Copy link
Contributor Author

Sorry, Below is the CLI to run. The HL7 output will go into the junk directory. Attached is the test file to use.

./prime data --input result_files/StandardCSV-Test.csv --input-schema manualupload/csvuploadertest-covid-19 --output-dir junk --route

StandardCSV-Test.csv

@oslynn
Copy link
Collaborator

oslynn commented Jan 8, 2022

@rick Hood where can I find the manualupload/csvuploadertest-covid-19?

@oslynn oslynn self-assigned this Jan 10, 2022
@CDCgov CDCgov deleted a comment from rick Feb 1, 2022
@jimduff-usds jimduff-usds removed the pipeline Cle, Jim, Yemi, Carlos, Gage, Derek, Ott label Mar 30, 2022
@oslynn
Copy link
Collaborator

oslynn commented Sep 12, 2022

Need to check with @MauriceReeves-usds to see if this issue still need to be fixed.

@oslynn
Copy link
Collaborator

oslynn commented Feb 24, 2023

This ticket can be close. We don't need to fix NET.1 any longer. If needed, we can reopen the ticket later. So far, there is no need and SLTLs never complain about this field.

@oslynn oslynn closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue Type label to flag an issue that is a bug High Priority Issue State label to flag an issue that is a high priority
Projects
None yet
Development

No branches or pull requests

4 participants