Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UTF-8 Encoding Headers #422

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

AFg6K7h4fhy2
Copy link
Collaborator

@AFg6K7h4fhy2 AFg6K7h4fhy2 commented Aug 29, 2024

Python3 uses UTF-8 encoding by default, so # -*- coding: utf-8 -*- in Python file headers is not needed. For clarity and minimalism of code, these are removed in this PR.

@AFg6K7h4fhy2 AFg6K7h4fhy2 added the clean up Good code that could be better label Aug 29, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the 🐦 Qiupalong milestone Aug 29, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Aug 29, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 linked an issue Aug 29, 2024 that may be closed by this pull request
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AFg6K7h4fhy2!

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.53%. Comparing base (1f7da68) to head (018a88e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #422   +/-   ##
=======================================
  Coverage   93.53%   93.53%           
=======================================
  Files          41       41           
  Lines        1021     1021           
=======================================
  Hits          955      955           
  Misses         66       66           
Flag Coverage Δ
unittests 93.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer merged commit 33ac845 into main Aug 29, 2024
8 checks passed
@damonbayer damonbayer deleted the 420-consistent-behavior-with-utf-8-encoding branch August 29, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent Behavior With UTF-8 Encoding
2 participants