Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

subset spatial 'mask' parameter shouldn't have resource selection enabled #699

Closed
JanisGailis opened this issue Jul 11, 2018 · 6 comments
Closed
Assignees

Comments

@JanisGailis
Copy link
Member

subset_spatial operation has a mask parameter which takes a Bool value to determine weather the output should be masked with the given region, or if the output should be cropped only to the bounding box of the given region.

In the operation invocation dialog this value has resource selection enabled leading to confusion - it can be understood that this is where the masking polygon should be provided:
image

@JanisGailis
Copy link
Member Author

By default the value selection switch is set to 'value' selection. It only gets automatically set to 'resource' selection in a very specific scenario:

A GeoDataFrame region is read in and selected, the subset_spatial is then invoked through right-clicking on a region (any) on the map and selecting subset_spatial from the context menu.

@forman
Copy link
Member

forman commented Jul 12, 2018

@JanisGailis Actually it should be ds that should receive the resource reference in this scenario, not mask. The code for this in TypeScript in the GUI, do you want to fix it on your own?

@JanisGailis
Copy link
Member Author

JanisGailis commented Jul 12, 2018

I quickly looked at it, but couldn't understand how to fix it properly. I think the problem is that the bool type can theoretically be whatever, so all resources correspond to that type and the box gets populated. So, the proper fix would be to make sure that only resources of actual type 'bool' get added to the resource list.

EDIT: Ah, yes and that this only happens when the operation dialog is invoked through the right-click context menu when clicking on a shape that is a resource.

@forman
Copy link
Member

forman commented Jul 13, 2018

Assign it to me or Hans, if you prefer.

@JanisGailis JanisGailis assigned forman and unassigned JanisGailis Jul 13, 2018
@JanisGailis
Copy link
Member Author

Re-assign to Hans if needed. It would've been nice to take a shot at fixing this, but I guess my time is better spent working on operations.

@forman
Copy link
Member

forman commented Sep 13, 2018

I agree, see #733

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants